Skip to content

[19.0][ADD] agreement_category: add agreement tagging functionality - #126

Open
MohamedOsman7 wants to merge 1 commit into
OCA:19.0from
c4a8-odoo:19.0-add-agreement_category
Open

[19.0][ADD] agreement_category: add agreement tagging functionality#126
MohamedOsman7 wants to merge 1 commit into
OCA:19.0from
c4a8-odoo:19.0-add-agreement_category

Conversation

@MohamedOsman7

Copy link
Copy Markdown
Contributor

No description provided.

@CRogos CRogos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max3903 max3903 added this to the 19.0 milestone Aug 16, 2026
@CRogos

CRogos commented Aug 19, 2026

Copy link
Copy Markdown

@vangnp3702 could you have a look on this feature disconnected from the agreement_legal discussion.

@max3903 max3903 self-assigned this Aug 28, 2026

@max3903 max3903 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added to agreement with a group and a setting.

@MohamedOsman7
MohamedOsman7 force-pushed the 19.0-add-agreement_category branch from 02f0bfe to 4a75003 Compare September 2, 2026 17:31
@CRogos

CRogos commented Sep 2, 2026

Copy link
Copy Markdown

Should be added to agreement with a group and a setting.

I disagree... with this agrument, Odoo would be exactly 1 module, because everything optional could also be implemented as group.

@CRogos

CRogos commented Sep 3, 2026

Copy link
Copy Markdown

@vangnp3702 what do you think about adding this to agreement?

But same argument could also be for the other modules, and I don't think we should add everything to agreements?
agreement_template #134
agreement_stage #135
agreement_type #136
agreement_termination #137
agreement_signature #138
agreement_revision #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants